[Infra UI] Display non-metric details on Node Detail page #43551
Conversation
- Closes elastic#42689 - Adds NodeDetails component
simianhacker
added
release_note:enhancement
Feature:Metrics UI
|
Pinging @elastic/infra-logs-ui |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
This will need a small update to the docs (this affects one of the few topics I've worked on so far, and got up-to-date). There is a screenshot to redo, and probably a few words to update. It's probably easiest if I do it and you review my changes to save the back and forth.
What's the best way to approach this? Can I make the changes as part of this PR, or give you the required changes so you can add them to this PR, or should I raise a separate issue? In this particular case, my personal preference is to get the docs changes in as part of this PR, because the changes are necessary but tiny. By the time we've gone to the overhead of raising another issue, planning and scheduling it, remembering what the issue was about and what needs to change, dealing with the review and processing, I could have done this change ten times over. :-)
💚 Build Succeeded |
💚 Build Succeeded |
|
@hbharding I've just sneaked in and done a tiny update to the docs to reflect this change. While redoing the screenshot, I wondered if it the time filter would be better moved below the metadata section? Currently, the time filter is above the metadata, but when the metadata is expanded, the time filter is quite a long way below the items it controls. I wonder whether a more intuitive position would be below the metadata section? |
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
x-pack/legacy/plugins/infra/public/components/metrics/node_details.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/components/metrics/node_details.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...
) * [Infra UI] Display non-metric details on Node Detail page - Closes elastic#42689 - Adds NodeDetails component * clean things up a bit * Change hook order * Start of docs changes * Making expand button more consitent * Update docs for this minor change * Changing handleClick to toggleIsOpen * Optimizing fields slice
…46049) * [Infra UI] Display non-metric details on Node Detail page - Closes #42689 - Adds NodeDetails component * clean things up a bit * Change hook order * Start of docs changes * Making expand button more consitent * Update docs for this minor change * Changing handleClick to toggleIsOpen * Optimizing fields slice
Summary
This PR closes #42689 by adding a metadata section to the top of the node details page.
Collapsed details
Expanded details
Collapsed details with missing data
Expanded details with missing data
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Unit or functional tests were updated or added to match the most common scenarios